Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace map with unordered_map #1295

Open
YuHsuan-Hwang opened this issue Aug 17, 2023 · 1 comment
Open

Replace map with unordered_map #1295

YuHsuan-Hwang opened this issue Aug 17, 2023 · 1 comment
Assignees
@markccchiang
Labels
code maintenance For issues relating to code maintenance and quality question Further information is requested
Milestone
v5.0-beta

Comments

@YuHsuan-Hwang
Copy link
Contributor

YuHsuan-Hwang commented Aug 17, 2023 •
edited

Code maintenance: ensure we use unordered_map instead of map for better performance.

This should probably be unordered_map, but I see that it's map in the existing code. There are a few other places where we're using map; this should probably be raised in a separate PR (I don't think there are any cases where we actually need an ordered map -- ensuring that we use unordered_map may improve performance, but map uses less memory, so perhaps this warrants further discussion).

Originally posted by @confluence in #1294 (comment)
@YuHsuan-Hwang YuHsuan-Hwang added the code maintenance For issues relating to code maintenance and quality label Aug 17, 2023
@YuHsuan-Hwang YuHsuan-Hwang mentioned this issue Aug 17, 2023
Merged
6 tasks
@confluence
Copy link
Collaborator

We should probably just replace map with unordered_map everywhere, but we should benchmark the change to make sure that it doesn't have any unintended consequences.

@kswang1029 kswang1029 added this to the v5.0-beta milestone Oct 3, 2023
@markccchiang markccchiang mentioned this issue Oct 21, 2023
Closed
6 tasks
@markccchiang markccchiang added the question Further information is requested label Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markccchiang markccchiang

Labels
code maintenance For issues relating to code maintenance and quality question Further information is requested
Projects
No open projects
CARTA
Status: PR test and review
CARTA - backend
Status: In progress
Milestone
v5.0-beta
Development

Successfully merging a pull request may close this issue.

Replace map with unordered map CARTAvis/carta-backend
4 participants
@confluence @markccchiang @kswang1029 @YuHsuan-Hwang