Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use the new Google Identity Services SDK before March 31, 2023 #131

Open
ajm-ska opened this issue Sep 22, 2022 · 3 comments
Open

Comments

@ajm-ska
Copy link

ajm-ska commented Sep 22, 2022

We use Google authentication in our carta-controller deployment at ASIAA.
I have received an email from Google stating:
[Action Required] Migrate to the new Google Identity Services library as soon as possible

One or more of your web applications uses the legacy Google Sign-In JavaScript library. Please migrate your project(s) to the new Google Identity Services SDK before March 31, 2023.

They provide a link to Instructions on how to do so: https://developers.google.com/identity/gsi/web/guides/migration
It looks like it will be easy to do, only requiring changes to a few lines.

@veggiesaurus
Copy link
Collaborator

@daikema is this something that we'll need to do once your OIDC stuff is merged in? Or do we no longer need the google libraries?

@daikema
Copy link
Contributor

daikema commented Sep 22, 2022

I think that once the OIDC stuff is merged in it should no longer to be necessary to have that separate Google auth process working. I tested using Google as IDP during the dev of that OIDC auth configuration to verify that it'd work and also had some students report success using it here as well.

@veggiesaurus
Copy link
Collaborator

Ok, then we can close this issue once your PR has been merged and tested with Google login

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Icebox
Development

No branches or pull requests

3 participants