Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draksetup doesn't set exit codes when operation fails #785

Open
psrok1 opened this issue May 9, 2023 · 0 comments
Open

draksetup doesn't set exit codes when operation fails #785

psrok1 opened this issue May 9, 2023 · 0 comments
Labels
bug Something isn't working certpl Fix requested by CERT.PL team drakrun/setup Issues related to draksetup command and the overall sandbox initialization/configuration process.

Comments

@psrok1
Copy link
Member

psrok1 commented May 9, 2023

Describe the bug

draksetup command doesn't set proper exit code when operation fails.

I've noticed that while debugging misbehaving test that passed this line https://github.com/CERT-Polska/drakvuf-sandbox/blob/master/test/conftest.py#L213 while being unable to download correct snapshot (... placeholder was provided instead of correct name)

[2023-04-07 15:48:42,943][INFO] Downloading installation info
[2023-04-07 15:48:42,945][DEBUG] http://192.168.100.1:8181/ "HEAD /snapshots/.../install.json HTTP/1.1" 404 0
[2023-04-07 15:48:42,945][ERROR] Import failed. Missing files in bucket.
INFO:root:VM provisioned, starting tests...
@psrok1 psrok1 added bug Something isn't working drakrun/setup Issues related to draksetup command and the overall sandbox initialization/configuration process. certpl Fix requested by CERT.PL team labels May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working certpl Fix requested by CERT.PL team drakrun/setup Issues related to draksetup command and the overall sandbox initialization/configuration process.
Projects
None yet
Development

No branches or pull requests

1 participant