Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected warning if no endpoint specified, #350

Open
ecow opened this issue Jul 19, 2021 · 4 comments
Open

Unexpected warning if no endpoint specified, #350

ecow opened this issue Jul 19, 2021 · 4 comments

Comments

@ecow
Copy link

ecow commented Jul 19, 2021

I think that to use the default endpoint should be perfectly legal, so probably the warning:

WARNING:No endpoint specified, using default

could be removed

@c-martinez
Copy link
Collaborator

True. Perhaps it is useful in debugging mode...

@ecow
Copy link
Author

ecow commented Jul 23, 2021

yes, it could be useful in debugging . I close the issue

@ecow ecow closed this as completed Jul 23, 2021
c-martinez pushed a commit to c-martinez/grlc that referenced this issue Jul 26, 2021
@ecow ecow reopened this Aug 4, 2021
@ecow
Copy link
Author

ecow commented Aug 4, 2021

I reopen this issue because looking to the code, it seams to me that in line 63 of src/gquery.py the line:

glogger.warning("No endpoint specified, using default ({})".format(endpoint))

could be rewitten as

glogger.info("No endpoint specified, using default ({})".format(endpoint))

In my opinion, Info is most appropriate level for this kind of log, also looking to similar cases in the same function.

Anyway it is just a very minor issue.

@c-martinez
Copy link
Collaborator

Thanks -- added that one to pending PR #355 on commit 6c2cf0a so it should all be merged together :-)

c-martinez pushed a commit to c-martinez/grlc that referenced this issue Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants