Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fall back to using a JSON retriever/parser in /makemember command #106

Open
CarrotManMatt opened this issue Dec 8, 2023 · 0 comments
Open

Fall back to using a JSON retriever/parser in /makemember command #106

CarrotManMatt opened this issue Dec 8, 2023 · 0 comments
Labels
refactor Improvements to the codebase that do not directly affect users

Comments

@CarrotManMatt
Copy link
Member

If the members-list is not stored on the Guild of Students website, the retriever should fall back to parsing the response as JSON. Rather than the currently hard-coded HTML parser for the specific table IDs.
@CarrotManMatt CarrotManMatt added the refactor Improvements to the codebase that do not directly affect users label Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor Improvements to the codebase that do not directly affect users
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@CarrotManMatt