Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration for pinging committee in welcome messages or not #176

Open
2 of 4 tasks
CarrotManMatt opened this issue Apr 15, 2024 · 3 comments · Fixed by #177
Open
2 of 4 tasks

Add configuration for pinging committee in welcome messages or not #176

CarrotManMatt opened this issue Apr 15, 2024 · 3 comments · Fixed by #177
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers suspended Delayed until a later date

Comments

@CarrotManMatt
Copy link
Member

CarrotManMatt commented Apr 15, 2024

Actual Incorrect Behaviour

Screenshot 2024-04-15 122021

Expected Behaviour

  • The role name should be correctly linked
  • If the role name cannot be linked, the role name should be output, preceded the @ (at) symbol. It should not include the angled braces like it currently does
  • An error message is output if TeX-Bot fails to substitute the role name correctly.
  • Add config flag for whether the welcome messages should ping committee or not
@CarrotManMatt CarrotManMatt added bug Something isn't working good first issue Good for newcomers labels Apr 15, 2024
@Thatsmusic99
Copy link
Member

I do hate to be a downer on this, but I felt like this was intentional? This is just my personal opinion but I'm not incredibly fond of being pinged every time this message rolls around - it will probably be funny at first, but I feel like I'd slowly get tired of it.

@CarrotManMatt
Copy link
Member Author

CarrotManMatt commented Apr 15, 2024

Ah very good point. I probably should have spoken to committee to get their thoughts on whether they wanted to be pinged.

I've just had a proper look and it's actually because of an issue in the original messages.json file, the substitution function code is actually fine. I will make it temporarily never ping committee (just have better formatting) and instead later add a config flag to allow for enabling/disabling it.

@CarrotManMatt CarrotManMatt self-assigned this Apr 15, 2024
@CarrotManMatt CarrotManMatt linked a pull request Apr 15, 2024 that will close this issue
@CarrotManMatt CarrotManMatt added enhancement New feature or request suspended Delayed until a later date and removed bug Something isn't working labels Apr 15, 2024
@CarrotManMatt
Copy link
Member Author

This now depends upon #165

@CarrotManMatt CarrotManMatt reopened this Apr 17, 2024
@CarrotManMatt CarrotManMatt changed the title Welcome messages still do not substitute role names correctly Add configuration for pinging committee in welcome messages or not May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers suspended Delayed until a later date
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants