Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make /archive command archive single channel #154

Open
CarrotManMatt opened this issue Jan 22, 2024 · 3 comments · May be fixed by #178
Open

Make /archive command archive single channel #154

CarrotManMatt opened this issue Jan 22, 2024 · 3 comments · May be fixed by #178
Assignees
@edwinchan129
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@CarrotManMatt
Copy link
Member

After the discussion in #1, the /archive command seems to have at least some desire to be implemented. However the current version will archive a whole category, whereas it will be more useful for the option to archive a single channel to be the primary functionality. Implementing the archival of a whole category can be delayed to a later date.
@CarrotManMatt CarrotManMatt added enhancement New feature or request good first issue Good for newcomers labels Jan 22, 2024
@edwinchan129
Copy link
Contributor

Could I take a look at this issue? I just have a few clarifying questions before I start.

  1. Would I need to consider channels with the same name, either in different categories or the same categories?
  2. If so, how would you prefer it be differentiated?
    - Include a category name in the autocomplete feature -> "CategoryName - ChannelName" (if we have to worry only
    about different categories
    - I haven't yet figured out how to deal with the situation of the same channel names within the same category, but maybe
    some kind of channel position indicator
  3. It seems like most of the changes that would need to be made would be in archive.py. Is there any other file I should be aware of?
  4. Has there been an additional desired changes outside what is mentioned here as the issue is from a while ago?

@CarrotManMatt
Copy link
Member Author

Would I need to consider channels with the same name, either in different categories or the same categories?

Pycord allows the use of function arguments to refer to a specific channel. This way the users can search for the channel by it's name, but the python code receives the unique ID of the channel, negating any issues arising from channels with the same name.
See Pycord's documentation on channel argument types & the guide on implementing them

It seems like most of the changes that would need to be made would be in archive.py. Is there any other file I should be aware of?

Nope, each cog is kept reasonably seperate for exactly this reason. So that future maintenance & development is easier.

Has there been an additional desired changes outside what is mentioned here as the issue is from a while ago?

Don't think so. We try to keep all of the discussion around development here in the GitHub issues so that it is traceable for exactly situations like this when we want to start implementing the discussed changes. It's much better than some offhand comment from a committee member being lost to time on a random Discord channel somewhere.

edwinchan129 added a commit to edwinchan129/TeX-Bot-Py-V2 that referenced this issue Apr 24, 2024
@edwinchan129
Fix Issue CSSUoB#154
c835dc3 
- Modify autocomplete to only display channels
- Modify archive to change permission for one channel
- Modify archive to add archive- before channel.name to mark it as archived
@edwinchan129
Copy link
Contributor

I more so meant the same channel name causing issues with the autocomplete feature the user wouldn't be able to easily differentiate the two apart.

@CarrotManMatt CarrotManMatt linked a pull request Apr 24, 2024 that will close this issue
Fix Issue CSSUoB#154 (Archive Single Channel) #178
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edwinchan129 edwinchan129

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Issue CSSUoB#154 (Archive Single Channel) edwinchan129/TeX-Bot-Py-V2
2 participants
@edwinchan129 @CarrotManMatt