Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve user facing messages from JSON file #90

Open
CarrotManMatt opened this issue Nov 21, 2023 · 2 comments · May be fixed by #209
Open

Retrieve user facing messages from JSON file #90

CarrotManMatt opened this issue Nov 21, 2023 · 2 comments · May be fixed by #209
Assignees
Labels
enhancement New feature or request

Comments

@CarrotManMatt
Copy link
Member

CarrotManMatt commented Nov 21, 2023

Using a JSON file to store user facing messages enables the opportunity to add translations, rather the strings being hard-coded.

This should also include the activity specific error messages defined in TeXBotCog.ERROR_ACTIVITIES.

Any command descriptions/button labels should also be retrieved from this JSON file.

@CarrotManMatt CarrotManMatt added the enhancement New feature or request label Nov 21, 2023
@sapphyree
Copy link
Contributor

I agree that reading from a file is good, but the real benefit is caching, and not translations? Translations don't really make any sense for a bot used on an English Discord server.

@CarrotManMatt
Copy link
Member Author

Oooh, yeah good point about caching. I wasn't planning on actually doing any translations, it just leaves the door open for future changes.

Either way, there are good reasons to do this.👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants