Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use full-res images in pictures. #428

Open
FrozenDude101 opened this issue Jun 21, 2023 · 3 comments
Open

Use full-res images in pictures. #428

FrozenDude101 opened this issue Jun 21, 2023 · 3 comments

Comments

@FrozenDude101
Copy link
Contributor

The full-res images are only a few MB in size.
There's probably some way to load the low-res images first, then load the high-res images. That way the site can still load quickly, and then the high-res images can replace the low-res ones as/once their loaded in.
This will make the committee page look better, but still be very fast to load.
There's also probably some way to detect if the user is on a metered connection, and only load the low-res images, but that's for someone else to figure out.

@codemicro
Copy link
Member

codemicro commented Jun 21, 2023

There's probably some way to load the low-res images first, then load the high-res images.

I believe this is only possible with extra added JS.

There's also probably some way to detect if the user is on a metered connection

Sort of? There's NetworkInformation, but that's still an experimental feature and not fully supported by every major browser.

Personally I err on the side of leaving it as-is for the sake of complexity, plus the fact that multiple MB is still quite a lot and I don't especially want a hi-res mugshot of myself on the public internet. That said I'm not opposed to the idea.

@FrozenDude101
Copy link
Contributor Author

FrozenDude101 commented Jun 22, 2023

I believe this is only possible with extra added JS.

Fairs, I know ways to do this with JS, and it seems there might be ways with CSS features, but I'll look into it a bit more over the next few days.

Sort of? There's NetworkInformation, but that's still an experimental feature and not fully supported by every major browser.

I'd argue that its minor to even detect this, it would only be an issue on the committee page (more so on the ex-committee page), but (as a guess, I don't have site statistics) most of the people visiting that are gonna be from areas where metered plans aren't very restrictive, or are from places with wifi readily available. More of a stretch goal if anything.

Personally I err on the side of leaving it as-is for the sake of complexity, plus the fact that multiple MB is still quite a lot and I don't especially want a hi-res mugshot of myself on the public internet. That said I'm not opposed to the idea.

Could be an extra tag on committee profiles, or people could put profile pics or something if they'd prefer, or just low-res pics into the full-res folder.

@codemicro
Copy link
Member

codemicro commented Jun 24, 2023

I have an even better idea - switch the image resizing script to resize to 250x250 instead of 150x150. That way, they're still fairly small images, but since the biggest image on the committee page as it stands comes in at ~230 pixels tall, no scaling-up will ever have to be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants