From 5826f55c7982cf5887dfd77f985fd8b04452c5c4 Mon Sep 17 00:00:00 2001 From: Christian Vuerings Date: Tue, 26 Mar 2024 14:49:30 -0700 Subject: [PATCH] Modal: fix close button in Cambio (#360) --- .changeset/ninety-rice-repair.md | 5 +++++ packages/syntax-core/src/Modal/Modal.tsx | 1 + 2 files changed, 6 insertions(+) create mode 100644 .changeset/ninety-rice-repair.md diff --git a/.changeset/ninety-rice-repair.md b/.changeset/ninety-rice-repair.md new file mode 100644 index 00000000..725addc6 --- /dev/null +++ b/.changeset/ninety-rice-repair.md @@ -0,0 +1,5 @@ +--- +"@cambly/syntax-core": minor +--- + +IconButton: make onClick required & fix modal close issue diff --git a/packages/syntax-core/src/Modal/Modal.tsx b/packages/syntax-core/src/Modal/Modal.tsx index ce30db69..cbe44055 100644 --- a/packages/syntax-core/src/Modal/Modal.tsx +++ b/packages/syntax-core/src/Modal/Modal.tsx @@ -215,6 +215,7 @@ export default function Modal({ accessibilityLabel={accessibilityCloseLabel} color={image ? "primary" : "tertiary"} on={image ? "darkBackground" : "lightBackground"} + onClick={onDismiss} size="sm" icon={XIconCambio} />