New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sonarcloud issues #243
Conversation
The current state shall bring down the number of issues nearly to resolved. How can I have a look at analysis of the PR I just contributed with your settings so that I can see the remaining sonar issues to solve? |
Thanks @rishi-raj-jain, |
So either I can update both ios & android or I can To ignore SonarCloud code smells for specific lines or blocks of code in a Swift project, you can one can use comments called "issue" or "noissue" comments. These comments allow you to provide information to SonarCloud regarding code smells that should be ignored or reported. Here's how you can use these comments in Swift:
|
Let me know which way makes sense to you |
Kudos, SonarCloud Quality Gate passed! |
It seems having static is uppercase is good practice in android, so I think for that one is better the Java way. |
Hey @riderx, Yeah that makes me wonder if we should only make changes to Swift? |
@rishi-raj-jain are you 100% sure you wanted to close this? |
fix #163
/claim #163