Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow metadata name parsed from class name prevents generated name from working #8

Open
yxue-kabam opened this issue Feb 25, 2020 · 2 comments
Labels
question Further information is requested

Comments

@yxue-kabam
Copy link

Description
Is it a design decision that any workflow class would have it's name attr set as "class-name" by default? While the metadata name is set, generated name will not take action.

e.g. class Helloworld(Workflow) would have 'hello-world' set as metadata name by default and used as pod name explicitly in k8s. I like the idea of leaving the name empty (or optional?) and default to generated-names, so I can submit the same workflow multiple times (since we cannot have duplicate pod names in k8s, at least while using the same node )

this is no a show stopper for me, I can always call wf.name = '', but current behaviour seems counter-intuitive.

Additional context
https://github.com/CermakM/argo-python-dsl/blob/master/argo/workflows/dsl/_workflow.py#L67

@yxue-kabam yxue-kabam added the question Further information is requested label Feb 25, 2020
@rosscdh
Copy link

rosscdh commented Apr 4, 2020

+1

@binarycrayon
Copy link
Contributor

now this works at https://github.com/argoproj-labs/argo-python-dsl/
if generate-name is specified then name is ommited

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants