Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shine is not working when removing the status bar #29

Open
jpjpjp28 opened this issue Nov 9, 2017 · 4 comments
Open

Shine is not working when removing the status bar #29

jpjpjp28 opened this issue Nov 9, 2017 · 4 comments

Comments

@jpjpjp28
Copy link

jpjpjp28 commented Nov 9, 2017

I'm trying to remove the status bar. The shine effect doesn't work after implementing the following code:

if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.KITKAT) {
val w: Window = window // in Activity's onCreate() for instance
w.setFlags(WindowManager.LayoutParams.FLAG_LAYOUT_NO_LIMITS,
WindowManager.LayoutParams.FLAG_LAYOUT_NO_LIMITS)
}

ChadCSong added a commit that referenced this issue Nov 13, 2017
@ChadCSong
Copy link
Owner

Resolved on version 0.2.0
Just replace with follow:
compile 'com.sackcentury:shinebutton:0.2.0'

@jpjpjp28
Copy link
Author

This is still an issue. Please reopen this issue.

@ChadCSong
Copy link
Owner

You can check my test code in MainActivity.java .
or Any other code was add?

@ChadCSong ChadCSong reopened this Nov 16, 2017
@jpjpjp28
Copy link
Author

The shine button is placed inside the NestedScrollView of a Scrolling Activity.

Here's the preview of my sample app, as you can see there's no shine effects:

shine_button_bug

PS: The activity I am using is not flagged as full screen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants