Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when it used on Android P,the ring was out of position #48

Open
summerhotready opened this issue Jan 2, 2019 · 11 comments
Open

when it used on Android P,the ring was out of position #48

summerhotready opened this issue Jan 2, 2019 · 11 comments

Comments

@summerhotready
Copy link

snipaste_2019-01-02_08-58-01
on Android P button like this.

@RiteshAdulkar
Copy link

I am facing the same issue, did you find out the solution?

@uscheller
Copy link

In my case, this happens when the keyboard is visible:
screenrecord_1551263186.mp4.zip

@XD-Z
Copy link

XD-Z commented Mar 1, 2019

I am facing the same issue, did you find out the solution?

@uscheller
Copy link

No, I ended up animating the button myself.

@ghost
Copy link

ghost commented Mar 9, 2019

This is not a problem with Android p, but a problem with a full-screen phone, failing to get the exact height of a full-screen phone.
bottomHeight = metrics.heightPixels - location[1];

@mcxinyu
Copy link

mcxinyu commented Mar 16, 2019

This is not a problem with Android p, but a problem with a full-screen phone, failing to get the exact height of a full-screen phone.
bottomHeight = metrics.heightPixels - location[1];

how do you fix this problem?

@lodgkk
Copy link

lodgkk commented Apr 22, 2019

I think I know why.because no consideration was given to the bottom navigation bar,but shineView showAnimation method isTranslucentNavigation(shineButton.activity)

if (isTranslucentNavigation(shineButton.activity)) {
if (isFullScreen(shineButton.activity)) {
centerAnimY = visibleFrame.height() - shineButton.getBottomHeight(false) + btnHeight / 2;
} else {
centerAnimY = visibleFrame.height() - shineButton.getBottomHeight(true) + btnHeight / 2;
}
} else {
centerAnimY = location[1] + btnHeight / 2;
}
No problems have been found so far.

@carlosalexandresmo
Copy link

Resolved this issue?

@ArcherEmiya05
Copy link

This is not a problem with Android p, but a problem with a full-screen phone, failing to get the exact height of a full-screen phone.
bottomHeight = metrics.heightPixels - location[1];

This is correct, my device is rooted and customized. I force it to fullscreen so that navigation and status bar are both immersive. By that the shine and ring was out of the position.

@ChadCSong
Copy link
Owner

This is not a problem with Android p, but a problem with a full-screen phone, failing to get the exact height of a full-screen phone.
bottomHeight = metrics.heightPixels - location[1];

This is correct, my device is rooted and customized. I force it to fullscreen so that navigation and status bar are both immersive. By that the shine and ring was out of the position.

Should you use 1.0.0 version to test this problem?I changed calculate location method.

@anhtuan23
Copy link

This is not a problem with Android p, but a problem with a full-screen phone, failing to get the exact height of a full-screen phone.
bottomHeight = metrics.heightPixels - location[1];

This is correct, my device is rooted and customized. I force it to fullscreen so that navigation and status bar are both immersive. By that the shine and ring was out of the position.

Should you use 1.0.0 version to test this problem?I changed calculate location method.

I tested it on Android P. I was having this problem before since I hid the navigation bar. Your fix works!
Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants