Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buffer.concat performance regression #4903

Open
dapplion opened this issue Dec 13, 2022 · 1 comment
Open

Buffer.concat performance regression #4903

dapplion opened this issue Dec 13, 2022 · 1 comment
Assignees
@matthewkeil
Labels
meta-investigate Issues found that require further investigation and may not have a specific resolution/fix prio-medium Resolve this some time soon (tm). scope-performance Performance issue and ideas to improve performance.

Comments

@dapplion
Copy link
Contributor

Describe the bug

On NodeJS v18 (merged in #4779) Buffer.concat got more expensive.

We decided to accept the regression for now to unblock v18. But must review and consider and mitigate when possible
@dapplion dapplion added prio-medium Resolve this some time soon (tm). scope-performance Performance issue and ideas to improve performance. labels Dec 13, 2022
@wemeetagain wemeetagain mentioned this issue Jun 5, 2023
Closed
4 tasks
@philknows
Copy link
Member

This requires investigation. It may have been fixed by node v20.x.

@philknows philknows added the meta-investigate Issues found that require further investigation and may not have a specific resolution/fix label Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthewkeil matthewkeil

Labels
meta-investigate Issues found that require further investigation and may not have a specific resolution/fix prio-medium Resolve this some time soon (tm). scope-performance Performance issue and ideas to improve performance.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@matthewkeil @dapplion @philknows