Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not produce a subgraph called default when no subgraph-config is available #7044

Open
Jonny-Collins opened this issue Apr 9, 2024 · 0 comments
Labels
Area: Fusion Issue is related to Hot Chocolate Fusion 🎉 enhancement New feature or request 🌶️ hot chocolate

Comments

@Jonny-Collins
Copy link

Product

Hot Chocolate

Is your feature request related to a problem?

When using the HotChocolate fusion commandline tool to pack a subgraph, it looks for the subgraph name in the subgraph-config.json. If it cannot find one, it uses the name default for the subgraph.

We had a bug recently where our subgraph-config was not being provided correctly to our composition step in CI and it was just producing a default subgraph and composing it. We had multiple services inherit this bug, so they were effectively overwriting each other's subgraphs in the composition.

This also tied particular types in the graph to the default subgraph so even after it was fixed, types were not updating as expected in the composed graph because they were still referenced to the default subgraph (which was not super obvious).

The solution you'd like

While these are just symptoms of our own bug, it might be more advantageous if the pack step would require a subgraph, and not revert to a default name value for the subgraph.

@Jonny-Collins Jonny-Collins added the 🎉 enhancement New feature or request label Apr 9, 2024
@michaelstaib michaelstaib added 🌶️ hot chocolate Area: Fusion Issue is related to Hot Chocolate Fusion labels Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Fusion Issue is related to Hot Chocolate Fusion 🎉 enhancement New feature or request 🌶️ hot chocolate
Projects
None yet
Development

No branches or pull requests

2 participants