Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review coercion rules regarding default values #878

Closed
michaelstaib opened this issue Jun 27, 2019 · 1 comment
Closed

Review coercion rules regarding default values #878

michaelstaib opened this issue Jun 27, 2019 · 1 comment
Assignees
@michaelstaib
Labels
🎨 refactoring This issue is about doing refactoring work, like cleaning up the code making existing code better.
Milestone
Backlog

Comments

@michaelstaib
Copy link
Member

That means whenever the argument is null we take the default reason.

We have to change it to this: That means whenever the argument is not provided we take the default reason.

We did the above rule wrong regarding to directive arguments and should fix this. There is however some issue here. When something was provided as a .net object than we cannot really detect if something was provided or is null.
@michaelstaib michaelstaib added the 🎨 refactoring This issue is about doing refactoring work, like cleaning up the code making existing code better. label Jun 27, 2019
@michaelstaib michaelstaib added this to the 9.1.0 milestone Jun 27, 2019
@michaelstaib michaelstaib self-assigned this Jun 27, 2019
@michaelstaib michaelstaib changed the title Review coercion rules regarding default values: Review coercion rules regarding default values Jun 27, 2019
@michaelstaib michaelstaib mentioned this issue Jun 27, 2019
Merged
@michaelstaib michaelstaib modified the milestones: 10.0.0, 11.0.0 Aug 7, 2019
@michaelstaib michaelstaib modified the milestones: HC-11.x.x, Backlog Mar 31, 2021
@tobias-tengler
Copy link
Collaborator

Closing in favor of #4179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelstaib michaelstaib

Labels
🎨 refactoring This issue is about doing refactoring work, like cleaning up the code making existing code better.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@michaelstaib @tobias-tengler