Back-port of #4143 for use in 11 (#4144)

Author: randyridge

src/HotChocolate/AspNetCore/src/AspNetCore/Subscriptions/WebSocketConnection.cs

@@ -11,7 +11,7 @@ namespace HotChocolate.AspNetCore.Subscriptions
     public class WebSocketConnection : ISocketConnection
     {
         private const string _protocol = "graphql-ws";
-        private const int _maxMessageSize = 1024 * 4;
+        private const int _maxMessageSize = 512;
         private WebSocket? _webSocket;
         private bool _disposed;
 
@@ -87,49 +87,35 @@ public async Task ReceiveAsync(
 
             try
             {
-                WebSocketReceiveResult? socketResult = null;
+                ValueWebSocketReceiveResult socketResult;
                 do
                 {
+                    if (webSocket.State != WebSocketState.Open)
+                    {
+                        break;
+                    }
+
                     Memory<byte> memory = writer.GetMemory(_maxMessageSize);
-                    var success = MemoryMarshal.TryGetArray(memory, out ArraySegment<byte> buffer);
+                    socketResult = await webSocket.ReceiveAsync(memory, cancellationToken);
 
-                    if (success)
+                    if (socketResult.Count == 0)
                     {
-                        if (webSocket.State != WebSocketState.Open)
-                        {
-                            break;
-                        }
-
-                        try
-                        {
-                            socketResult = await webSocket.ReceiveAsync(buffer, cancellationToken);
-                            if (socketResult.Count == 0)
-                            {
-                                break;
-                            }
-
-                            writer.Advance(socketResult.Count);
-                        }
-                        catch
-                        {
-                            break;
-                        }
-
-                        FlushResult result = await writer.FlushAsync(cancellationToken);
-                        if (result.IsCompleted)
-                        {
-                            break;
-                        }
+                        break;
                     }
-                } while (socketResult == null || !socketResult.EndOfMessage);
-            }
-            catch (ObjectDisposedException)
-            {
-                // we will just stop receiving
+
+                    writer.Advance(socketResult.Count);
+
+                    FlushResult result = await writer.FlushAsync(cancellationToken);
+
+                    if (result.IsCompleted)
+                    {
+                        break;
+                    }
+                } while (!socketResult.EndOfMessage);
             }
-            catch (WebSocketException)
+            catch
             {
-	            // we will just stop receiving
+                // swallow exception, there's nothing we can reasonably do
             }
         }