Changed the whay we resolver the type from the runtime type. (#3869)

Author: michaelstaib

src/HotChocolate/Core/src/Types/Types/ObjectType.cs

@@ -144,7 +144,7 @@ private void CompleteTypeResolver(ITypeCompletionContext context)
                 }
                 else
                 {
-                    _isOfType = IsOfTypeWithClrType;
+                    _isOfType = IsOfTypeWithRuntimeType;
                 }
             }
         }
@@ -164,17 +164,10 @@ private bool ValidateFields(
             return !hasErrors;
         }
 
-        private bool IsOfTypeWithClrType(
+        private bool IsOfTypeWithRuntimeType(
             IResolverContext context,
-            object? result)
-        {
-            if (result is null)
-            {
-                return true;
-            }
-
-            return RuntimeType.IsInstanceOfType(result);
-        }
+            object? result) =>
+            result is null || RuntimeType == result.GetType();
 
         private bool IsOfTypeWithName(
             IResolverContext context,

src/HotChocolate/Core/test/Types.Tests/CodeFirstTests.cs

@@ -3,7 +3,10 @@
 using System;
 using System.Threading;
 using System.Threading.Tasks;
+using HotChocolate.Execution;
+using HotChocolate.Tests;
 using HotChocolate.Types;
+using Microsoft.Extensions.DependencyInjection;
 using Snapshooter.Xunit;
 using Xunit;
 
@@ -97,6 +100,44 @@ public void Infer_Interface_Usage_With_Interfaces_Implementing_Interfaces()
                 .MatchSnapshot();
         }
 
+        [Fact]
+        public async Task Default_Type_Resolution_Shall_Be_Exact()
+        {
+            Snapshot.FullName();
+
+            await new ServiceCollection()
+                .AddGraphQL()
+                .AddQueryType(d =>
+                {
+                    d.Name("Query");
+                    d.Field("shouldBeCat").Type<InterfaceType<IPet>>().Resolve(new Cat());
+                    d.Field("shouldBeDog").Type<InterfaceType<IPet>>().Resolve(new Dog());
+                })
+                .AddType<Dog>()
+                .AddType<Cat>()
+                .ExecuteRequestAsync("{ shouldBeCat { __typename } shouldBeDog { __typename } }")
+                .MatchSnapshotAsync();
+        }
+
+        [Fact]
+        public async Task Default_Type_Resolution_Shall_Be_Exact_Schema()
+        {
+            Snapshot.FullName();
+
+            await new ServiceCollection()
+                .AddGraphQL()
+                .AddQueryType(d =>
+                {
+                    d.Name("Query");
+                    d.Field("shouldBeCat").Type<InterfaceType<IPet>>().Resolve(new Cat());
+                    d.Field("shouldBeDog").Type<InterfaceType<IPet>>().Resolve(new Dog());
+                })
+                .AddType<Dog>()
+                .AddType<Cat>()
+                .BuildSchemaAsync()
+                .MatchSnapshotAsync();
+        }
+
         public class Query
         {
             public string SayHello(string name) =>
@@ -163,6 +204,10 @@ public class Dog : IPet
                 throw new NotImplementedException();
         }
 
+        public class Cat : Dog
+        {
+        }
+
         public class QueryWithDateTimeType : ObjectType<QueryWithDateTime>
         {
             protected override void Configure(IObjectTypeDescriptor<QueryWithDateTime> descriptor)

src/HotChocolate/Core/test/Types.Tests/__snapshots__/CodeFirstTests.Default_Type_Resolution_Shall_Be_Exact.snap

@@ -0,0 +1,10 @@
+{
+  "data": {
+    "shouldBeCat": {
+      "__typename": "Cat"
+    },
+    "shouldBeDog": {
+      "__typename": "Dog"
+    }
+  }
+}

src/HotChocolate/Core/test/Types.Tests/__snapshots__/CodeFirstTests.Default_Type_Resolution_Shall_Be_Exact_Schema.snap

@@ -0,0 +1,26 @@
+schema {
+  query: Query
+}
+
+interface IPet {
+  name: String
+}
+
+type Cat implements IPet {
+  name: String
+}
+
+type Dog implements IPet {
+  name: String
+}
+
+type Query {
+  shouldBeCat: IPet
+  shouldBeDog: IPet
+}
+
+"The `@defer` directive may be provided for fragment spreads and inline fragments to inform the executor to delay the execution of the current fragment to indicate deprioritization of the current fragment. A query with `@defer` directive will cause the request to potentially return multiple responses, where non-deferred data is delivered in the initial response and data deferred is delivered in a subsequent response. `@include` and `@skip` take precedence over `@defer`."
+directive @defer("If this argument label has a value other than null, it will be passed on to the result of this defer directive. This label is intended to give client applications a way to identify to which fragment a deferred result belongs to." label: String "Deferred when true." if: Boolean) on FRAGMENT_SPREAD | INLINE_FRAGMENT
+
+"The `@stream` directive may be provided for a field of `List` type so that the backend can leverage technology such as asynchronous iterators to provide a partial list in the initial response, and additional list items in subsequent responses. `@include` and `@skip` take precedence over `@stream`."
+directive @stream("If this argument label has a value other than null, it will be passed on to the result of this stream directive. This label is intended to give client applications a way to identify to which fragment a streamed result belongs to." label: String "The initial elements that shall be send down to the consumer." initialCount: Int! "Streamed when true." if: Boolean!) on FIELD

src/StrawberryShake/Client/test/Core.Tests/Serialization/UuidSerializerTests.cs

@@ -1,6 +1,6 @@
-using System;
+using System;
 using StrawberryShake;
-using StrawberryShake.Serialization;
+using StrawberryShake.Serialization;
 using Xunit;
 
 namespace Core.Tests.Serialization
@@ -16,7 +16,7 @@ public class UuidSerializerTests
         public void Parse_Different_Formats(string format)
         {
             // arrange
-            var serializer = new UUIDSerializer();
+            var serializer = new UuidSerializer();
             var guid = Guid.NewGuid();
 
             // act
@@ -30,7 +30,7 @@ public void Parse_Different_Formats(string format)
         public void Parse_Exception()
         {
             // arrange
-            var serializer = new UUIDSerializer();
+            var serializer = new UuidSerializer();
 
             // assert
             Assert.Throws<GraphQLClientException>(() => serializer.Parse(string.Empty));
@@ -45,7 +45,7 @@ public void Parse_Exception()
         public void Format(string format)
         {
             // arrange
-            var serializer = new UUIDSerializer(format: format);
+            var serializer = new UuidSerializer(format: format);
             var guid = Guid.NewGuid();
 
             // act