Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change PaginationAmount IntType registration #2985

Merged
merged 4 commits into from
Aug 23, 2021
Merged

Change PaginationAmount IntType registration #2985

merged 4 commits into from
Aug 23, 2021

Conversation

LandryDubus
Copy link
Contributor

Change PaginationAmount IntType registration no the gateway side in order to prevent the following error on schema reload:
"Operation is not valid due to the current state of the object. (HotChocolate.Types.IntType)"

LandryDubus and others added 2 commits February 1, 2021 13:57

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
In order to prevent the following error on schema reload:
"Operation is not valid due to the current state of the object. (HotChocolate.Types.IntType)"

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Member

@michaelstaib michaelstaib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ConfigureSchema is not meant for users but for extensions.

@michaelstaib
Copy link
Member

I see what the issue is, but I do not want people to use the underlying schema builder anymore since we are going to refactor it with version 12. So there should be no dependency on it.

What we can do is introduce a new AddType overload that allows for a factory approach.

AddType(() => new IntType())

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@michaelstaib michaelstaib merged commit ddc8479 into ChilliCream:main Aug 23, 2021
myieye added a commit to sillsdev/languageforge-lexbox that referenced this pull request Nov 11, 2024
…rent state of the object. (DateTimeType)

Stumbled upon this solution here: ChilliCream/graphql-platform#2985 (comment)
hahn-kev added a commit to sillsdev/languageforge-lexbox that referenced this pull request Nov 12, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…rent state of the object. (DateTimeType) (#1227)

* Prevent error after hot reload: Operation is not valid due to the current state of the object. (DateTimeType)
Stumbled upon this solution here: ChilliCream/graphql-platform#2985 (comment)

* remove manually added graphql types which are automatically defined

---------

Co-authored-by: Kevin Hahn <kevin_hahn@sil.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants