Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a store less generation option for strawberry shake #3418

Merged
merged 6 commits into from
Apr 6, 2021
Merged

Added a store less generation option for strawberry shake #3418

merged 6 commits into from
Apr 6, 2021
+12,351 −343

Conversation

PascalSenn
Copy link
Member

Closes #3403 , #3392

@PascalSenn PascalSenn linked an issue Apr 2, 2021 that may be closed by this pull request
Review Strawberry Shake IClientError nullability of collection members #3392
Closed
@PascalSenn PascalSenn requested a review from michaelstaib April 2, 2021 22:23
@PascalSenn PascalSenn added the 🎬 ready Ready to merge label Apr 2, 2021
@PascalSenn
Copy link
Member Author

@michaelstaib I did not add a tests for subscriptions to avoid another flaky test. Should I test the NoStoreOperationExecutor?
Also, could you try this generation behaviour on one of your fancy Blazor apps?

michaelstaib
michaelstaib previously approved these changes Apr 6, 2021
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 6, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 13 Code Smells

81.8% 81.8% Coverage
2.7% 2.7% Duplication

@michaelstaib michaelstaib merged commit 7ae9b57 into main Apr 6, 2021
@michaelstaib michaelstaib deleted the pse/store-less-ss branch April 6, 2021 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelstaib michaelstaib

Assignees
No one assigned
Labels
🎬 ready Ready to merge
Projects
None yet
Milestone
No milestone
2 participants
@PascalSenn @michaelstaib