-
-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect and fix broken links #3746
Conversation
5ec39d0
to
3fab54a
Compare
3fab54a
to
128897e
Compare
@tobias-tengler could you please solve the conflicts so I can start the review 😄 |
128897e
to
a546188
Compare
9a6aa53
to
bf20c62
Compare
Okay I've noticed two issues with this just now.
Will look into these problems tomorrow. |
Okay I can't get it to work with I think it is fine like it is though. It will discover broken links in CI and when I also significantly improved the performance in comparison to my initial attempt, by splitting the gathering of links and validation of those links into two separate local plugins. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you!
@tobias-tengler could you please fix the conflict then we could merge 👍 |
@rstaib done! ✅ EDIT: One of the Hot Chocolate tests has been stuck for 17min 😭 |
/AzurePipelines run |
Azure Pipelines successfully started running 2 pipeline(s). |
Kudos, SonarCloud Quality Gate passed! |
Not sure why the Website pipeline also ran 17min this time. It seems to have been stuck on the onPostBuild, which this PR doesn't modify. I tested locally again and the link validation is definitely not at fault here. I would attribute it to degraded Pipeline performance of DevOps at the moment... |
@tobias-tengler Let's see if the perf issue is persistent and tackle it then in another issue. |
Happened again in the pipeline, while other PRs ran with a similar time. I'm not yet sure what's causing this, the link validation is already done, once the stalling hits. I'll look further into it tomorrow. |
* Detect dead links * Fix broken links * Link using the absolute path * Fix dead blog post links (in theory) * Use slug field as slug * Support validation of non inline links * Be more explicit about header discovery * Fix some more links * Fix broken links * Split gathering and validation of links into two plugins * Use reporter for output Conflicts: website/package.json website/src/docs/hotchocolate/defining-a-schema/scalars.md website/src/docs/strawberryshake/performance/index.md website/yarn.lock
* Detect dead links * Fix broken links * Link using the absolute path * Fix dead blog post links (in theory) * Use slug field as slug * Support validation of non inline links * Be more explicit about header discovery * Fix some more links * Fix broken links * Split gathering and validation of links into two plugins * Use reporter for output
I essentially moved the code of gatsby-remark-check-links into this repository and made some changes. The original plugin has some flaws that make it incompatible with our website and it is also no longer maintained by the original author.
Changes
/hotchocolate/get-started/
, now:/docs/hotchocolate/get-started
)