Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New version selection experience #3925

Merged
merged 10 commits into from
Jul 7, 2021
Merged

New version selection experience #3925

merged 10 commits into from
Jul 7, 2021
+472 −445

Conversation

tobias-tengler
Copy link
Collaborator

@tobias-tengler tobias-tengler commented Jul 4, 2021 •
edited
Loading

Changes

  • New dropdown control to select version of current product
    image
  • Warning for outdated documentation
    image
  • Cleanup of navigation rendering logic

Preview: https://chilly-version-selection.netlify.app/docs/hotchocolate/

@tobias-tengler tobias-tengler changed the base branch from develop to main July 4, 2021 16:53
@tobias-tengler tobias-tengler force-pushed the tte/new-version-selection branch from 5ec6776 to 6b7cf43 Compare July 4, 2021 19:14
@tobias-tengler tobias-tengler marked this pull request as ready for review July 4, 2021 19:15
@tobias-tengler tobias-tengler changed the title WIP: New version selection experience New version selection experience Jul 4, 2021
@tobias-tengler tobias-tengler requested a review from rstaib July 4, 2021 19:15
@tobias-tengler tobias-tengler self-assigned this Jul 4, 2021
@arif-hanif arif-hanif self-requested a review July 5, 2021 13:30
arif-hanif
arif-hanif previously approved these changes Jul 5, 2021
View reviewed changes
@rstaib
Copy link
Member

rstaib commented Jul 5, 2021

Looks pretty good!

@tobias-tengler
Copy link
Collaborator Author

@rstaib done!
Could we maybe first get #3879 in, then I can re-use the variables I declared there here.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 5, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@rstaib
Copy link
Member

rstaib commented Jul 6, 2021

@tobias-tengler merged #3879 👍

@tobias-tengler
Merge branch 'main' into tte/new-version-selection

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
f37e233
@tobias-tengler
Use CSS variables
9df5747
@tobias-tengler tobias-tengler requested a review from rstaib July 7, 2021 16:52
rstaib
rstaib approved these changes Jul 7, 2021
View reviewed changes
Copy link
Member

@rstaib rstaib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cool!

@rstaib rstaib merged commit e45e9d7 into main Jul 7, 2021
@rstaib rstaib deleted the tte/new-version-selection branch July 7, 2021 18:07
tobias-tengler added a commit that referenced this pull request Jul 9, 2021
@tobias-tengler
New version selection experience (#3925)
657dafe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rstaib rstaib

@arif-hanif arif-hanif

Assignees

@tobias-tengler tobias-tengler

Labels
🌶️ website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tobias-tengler @rstaib @arif-hanif