Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align code style of website with BCP #3940

Merged
merged 8 commits into from
Aug 2, 2021
Merged

Align code style of website with BCP #3940

merged 8 commits into from
Aug 2, 2021
+302 −338

Conversation

tobias-tengler
Copy link
Collaborator

@rstaib as discussed on Slack:

  • ComponentProperties --> ComponentProps
  • React.FunctionComponent --> React.FC

@tobias-tengler tobias-tengler requested a review from rstaib July 9, 2021 17:55
@tobias-tengler tobias-tengler self-assigned this Jul 10, 2021
rstaib
rstaib approved these changes Jul 15, 2021
View reviewed changes
Copy link
Member

@rstaib rstaib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 1, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@tobias-tengler tobias-tengler merged commit 95751b1 into main Aug 2, 2021
@tobias-tengler tobias-tengler deleted the tte/align-website-code-with-bcp branch August 2, 2021 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rstaib rstaib

Assignees

@tobias-tengler tobias-tengler

Labels
🌶️ website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tobias-tengler @rstaib