Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated private DSN #55

Open
ChristophWurst opened this issue Dec 5, 2018 · 3 comments
Open

Remove deprecated private DSN #55

ChristophWurst opened this issue Dec 5, 2018 · 3 comments

Comments

@ChristophWurst
Copy link
Owner

Feature Request

Only use the "public" DSN.

From https://docs.sentry.io/error-reporting/quickstart/?platform=javascript#configure-the-sdk

As of Sentry 9, we removed the need to provide the secret key. Older versions of SDKs may still require you to provide the DSN including the secret which is now called DSN (Legacy).

⚠️ might not work for older, on-premise installations getsentry/sentry-electron#61.

@rullzer
Copy link
Collaborator

rullzer commented Mar 25, 2019

I'd say we just kill of the public-dsn with v5

@rullzer
Copy link
Collaborator

rullzer commented Mar 25, 2019

Ah wait we need some migration step indeed. Ok then lets do a DSN service that just grabs the right DSN. And then put a warning up somewhere.

@ChristophWurst
Copy link
Owner Author

I would do a simple migration step.

If the public dsn is set, we're done. Otherwise, the private dsn should be set (this was the requirement in the past). We pass that to Raven_Client::parseDsn(), build a new one without the password and set it as public dsn.

Then we don't need any warning. The migration should just work for all installations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants