Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure retries for docker pull operations #222

Open
DaJoTo opened this issue Aug 23, 2022 · 2 comments
Open

Configure retries for docker pull operations #222

DaJoTo opened this issue Aug 23, 2022 · 2 comments
Assignees
Labels
backlog Identified as a backlog item, often combined with low-priority and help-wanted labels enhancement New feature or request

Comments

@DaJoTo
Copy link

DaJoTo commented Aug 23, 2022

What would you like to be added

Would be nice to see the addition of a parameter that sits above any commands that do docker pull operations. This parameter would just be a number to stipulate how many times the script should retry docker pull failures before aborting the pipeline

Something like:
docker-pull-retries: 3

Why is this needed

The majority of our pipeline failures occur around a TLS timeout when doing pull operations (in our case doing the build-and-push-image command). The impact of this failure can be reduced by implementing a pause and retry pattern.

example of error:

Successfully created context "builder"
Unable to find image 'tonistiigi/binfmt:latest' locally
latest: Pulling from tonistiigi/binfmt

64c318a5: Pulling fs layer 
docker: error pulling image configuration: ... : net/http: TLS handshake timeout.
@DaJoTo DaJoTo added the enhancement New feature or request label Aug 23, 2022
@brivu brivu self-assigned this Nov 8, 2022
@brivu brivu added the backlog Identified as a backlog item, often combined with low-priority and help-wanted labels label Dec 12, 2022
@brivu
Copy link
Contributor

brivu commented Dec 12, 2022

Hey @DaJoTo,

Thanks for opening this issue. While it could be done, it does add some verbosity to the parameters. We’ll wait for a while to look for any community feedback before moving forward. I've added this to our backlog for now.

Thanks again!

Best,
Brian

@michael-cybrid
Copy link

Would really like this.

Similar to #215, we experience regular enough failures due to connectivity issues that having a built in ability to retry would be of tremendous value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Identified as a backlog item, often combined with low-priority and help-wanted labels enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants