Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

circleci/hugo@1.3.0: --error-sort flag fails to build #51

Open
jwflory opened this issue Feb 15, 2022 · 5 comments
Open

circleci/hugo@1.3.0: --error-sort flag fails to build #51

jwflory opened this issue Feb 15, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@jwflory
Copy link
Contributor

jwflory commented Feb 15, 2022

Orb version

1.3.0

What happened

The --error-sort flag behaves unexpectedly and fails the HTML-Proofer step when running a build. See a log here.

Stacktrace for reference:

Traceback (most recent call last):
	4: from /usr/local/bin/htmlproofer:23:in `<main>'
	3: from /usr/local/bin/htmlproofer:23:in `load'
	2: from /var/lib/gems/2.7.0/gems/html-proofer-3.19.3/bin/htmlproofer:11:in `<top (required)>'
	1: from /var/lib/gems/2.7.0/gems/mercenary-0.4.0/lib/mercenary.rb:21:in `program'
/var/lib/gems/2.7.0/gems/mercenary-0.4.0/lib/mercenary/program.rb:33:in `go': invalid argument: --error-sort  (OptionParser::InvalidArgument)

I guess my change in #47 was half-baked. 😞 Not sure how best to debug this one.

Expected behavior

HTML-Proofer successfully validates the HTML according to user preference.
@jwflory jwflory added the bug Something isn't working label Feb 15, 2022
This was referenced Feb 15, 2022
Open
Closed
Open
Open
Open
@jwflory
Copy link
Contributor Author

jwflory commented Feb 23, 2022 •
edited

It appears a read-only key was used in the orb-tools/dev-promote-prod-from-commit-subject job from the integration-tests_prod-release workflow. I don't think this is related to the HTML-Proofer error in the above stacktrace though.

@jwflory jwflory mentioned this issue Feb 23, 2022
Merged
@jwflory
Copy link
Contributor Author

jwflory commented Mar 9, 2022

Any possibility this could be fixed? The orb is broken in the latest version. Or, if you have any pointers on how to fix it, I can try to make my own attempt at it.

@jwflory jwflory mentioned this issue Mar 10, 2022
Open
@jwflory
Copy link
Contributor Author

jwflory commented Mar 10, 2022

Since a lot of this trouble with htmlproofer appears to come from unexpected behavior by the --error-sort flag, I opened gjtorikian/html-proofer#701 to seek clarity on this upstream.

jwflory added a commit to unicef/coach that referenced this issue Mar 11, 2022
@jwflory
🐛 ⚗️ ci: Downgrade CircleCI Hugo Orb to v1.2.2
ed77c66 
I accidentally committed the change with the CircleCI Orb for Hugo at
version 1.3.0. However, this version is broken and will not complete
successfully in the pipeline (see CircleCI-Public/hugo-orb#51).

This commit gets the CI pipeline to run successfully again.

Signed-off-by: Justin W. Flory (he/him) [UNICEF Innovation] <jflory@unicef.org>
jwflory added a commit to unicef/coach that referenced this issue Mar 11, 2022
@jwflory
🐛 ⚗️ ci: Downgrade CircleCI Hugo Orb to v1.2.2
3fdb7c4 
I accidentally committed the change with the CircleCI Orb for Hugo at
version 1.3.0. However, this version is broken and will not complete
successfully in the pipeline (see CircleCI-Public/hugo-orb#51).

This commit gets the CI pipeline to run successfully again.

Signed-off-by: Justin W. Flory (he/him) [UNICEF Innovation] <jflory@unicef.org>
AdamGleave added a commit to AdamGleave/website that referenced this issue Mar 14, 2022
@AdamGleave
Downgrade orb to workaround CircleCI-Public/hugo-orb#51
59256b8
AdamGleave added a commit to AdamGleave/website that referenced this issue Mar 14, 2022
@AdamGleave
Fix CircleCI (#4)
15d4812 
* Update CircleCI config

* Downgrade orb to workaround CircleCI-Public/hugo-orb#51
@Jaryt
Copy link
Contributor

Jaryt commented Nov 14, 2022

Looking into this now! Sorry for the delay

@MattiSG MattiSG mentioned this issue Nov 25, 2022
Merged
@jwflory
Copy link
Contributor Author

jwflory commented Nov 25, 2022

@Jaryt Thank you. Please share an update here when a new version is published in the registry. I'll test a new release in the five Pull Requests referenced at the top of the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Jaryt @jwflory