Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wave a11y report errors for material theme #981

Closed
1 task done
dmundra opened this issue Dec 27, 2022 · 3 comments
Closed
1 task done

Wave a11y report errors for material theme #981

dmundra opened this issue Dec 27, 2022 · 3 comments
Assignees

Comments

@dmundra
Copy link
Collaborator

dmundra commented Dec 27, 2022

Wave is reporting a lot of errors for the material theme (currently 34 errors https://wave.webaim.org/report#/https://handbook.civicactions.com/en/latest/ and 8 contrast errors when using the browser tool).

To dos

  • Fix contrast errors in the "read the docs" popup that allows switching of branches.

Follow-up on the Wave a11y errors (see quote below from #926)

Looks like the a11y issues are known:

For the keyboard navigation for sub-topics one option is enabling navigation sections and navigation expansion (https://squidfunk.github.io/mkdocs-material/setup/setting-up-navigation/#navigation-sections). We can also introduce tabs, if we overhaul the menu. Right now all top level pages would be tabs and that is a lot of tabs.

@dmundra dmundra self-assigned this Dec 27, 2022
@ContentBrewmaster
Copy link
Contributor

@dmundra
Copy link
Collaborator Author

dmundra commented Jan 9, 2023

Fix for contrast errors in #1004 and also the keyboard navigation for collapsed menu items is fixed the latest version (9.0.3).

@dmundra
Copy link
Collaborator Author

dmundra commented Jan 19, 2023

I believe the author will be fixing accessibility errors so as long as we keep our version up to date then we should get those fixes. I don't think wave errors will go down to 0 based on the architecture of the theme so for now closing this issue.

@dmundra dmundra closed this as completed Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants