Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on syntax error while loading test files #256

Merged
merged 2 commits into from
Jan 20, 2022

Conversation

CleanCut
Copy link
Owner

@CleanCut CleanCut commented Jan 20, 2022

  • Stop silently ignoring crashes on some loading paths. Notably, when
    you specified a dotname for the target to test and the module had a
    syntax error, then the module was being silently skipped.
  • This changes the behavior when targets are being loaded by filename
    and have a syntax error. Previously we were converting the syntax
    error into a single test failure representing failing to load the
    module. Now the crash occurs before we get that far.

Separately, I removed the GitHub action that tries to add a special label for my sponsors.

  1. I don't offer that "benefit" anymore
  2. The action seems to be broken, anyway.

Resolves #255

- Stop silently ignoring crashes on some loading paths. Notably, when
  you specified a dotname for the target to test and the module had a
  syntax error, then the module was being silently skipped.
- This changes the behavior when targets are being loaded by filename
  and have a syntax error. Previously we were converting the syntax
  error into a single test failure representing failing to load the
  module. Now the crash occurs before we get that far.
@coveralls
Copy link

coveralls commented Jan 20, 2022

Coverage Status

Coverage remained the same at 100.0% when pulling fcecacc on detect-dotname-syntax-error into e75ce6a on main.

@CleanCut CleanCut merged commit b4caaa1 into main Jan 20, 2022
@CleanCut CleanCut deleted the detect-dotname-syntax-error branch January 20, 2022 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SyntaxError not catched when named explicte but unittest does
2 participants