Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for different themes based on Terminal color scheme #1284

Open
1 task done
proletarius101 opened this issue Aug 26, 2023 · 3 comments
Open
1 task done

Support for different themes based on Terminal color scheme #1284

proletarius101 opened this issue Aug 26, 2023 · 3 comments
Labels
feature Requests for a new feature.

Comments

@proletarius101
Copy link

Checklist

Describe the feature request

Currently, the bottom program only allows for specification of one theme using --color --color default-light. However, it would be more efficient if we could implement automatic detection of light or dark theme variants to match the theme variant of the terminal program, preventing ineligibility when switching between terminal theme variants. This feature is particularly useful when the terminal is set to use system color.

Implementation

The termbg library, available at https://github.com/dalance/termbg, is useful for implementing this feature.

Relevant tickets

@proletarius101 proletarius101 added the feature Requests for a new feature. label Aug 26, 2023
@ClementTsang
Copy link
Owner

Hmm... interesting, I can look into that.

Might also have to consider it should interact with custom colour schemes in the config - I guess I could open up a section for dark mode custom colours if someone wanted to specify custom light and dark mode themes.

@MichalBryxi
Copy link
Contributor

I hate to be that person, but: Any news on this? My terminal(well, whole OS) color scheme changes at least two times per day. So not having to care about extra cmd line flag every time would be awesome.

@ClementTsang
Copy link
Owner

Haven't had too much time so not yet, sorry! Can try to take a look when I have time as I think this isn't too hard to do though, I think I can borrow a lot of the lessons/ideas from the linked bat issue too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Requests for a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants