Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect game loading #73845

Open
IdleSol opened this issue May 16, 2024 · 4 comments
Open

Incorrect game loading #73845

IdleSol opened this issue May 16, 2024 · 4 comments
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility

Comments

@IdleSol
Copy link

IdleSol commented May 16, 2024

Describe the bug

I got several error messages during the loading process. But I assume that they are the result of an error during game loading, which has specific conditions of occurrence and does not cause an error report.

If you create a world with the Limb stuff mod and then delete it (world). Then loading a new world without the mod, leads to the following reports.

 DEBUG    : invalid body part id "arm_wing_bird_l"
 DEBUG    : invalid body part id "arm_wing_bird_r"

 FUNCTION : const T& generic_factory<T>::obj(const string_id<T>&) const [with T = body_part_type]
 FILE     : src/generic_factory.h
 LINE     : 482
 VERSION  : cdda-experimental-2024-05-16-0649 d435fb1

 DEBUG    : invalid sub body part id "arm_wing_bird_lower_r"
 DEBUG    : invalid sub body part id "arm_wing_bird_lower_l"

 FUNCTION : const T& generic_factory<T>::obj(const string_id<T>&) const [with T = sub_body_part_type]
 FILE     : src/generic_factory.h
 LINE     : 482
 VERSION  : cdda-experimental-2024-05-16-0649 d435fb1

These reports appear at the martial arts finalization stage or somewhere around there. (finalizing/recipe groups or martial arts).

I assume that the game is accessing data from the mod. But since it is disabled, it gets an error. The question is, why is it trying to access it?

Attach save file

n/a

Steps to reproduce

  1. Create a world with the Limb stuff mod
  2. Select to create a new character (new game / custom character)
  3. Wait for the download to complete
  4. Exit the character customization menu to the main menu
  5. Delete the world
  6. Create a new world, but without the mod
  7. Select to create a new character
  8. Get an error while loading

Expected behavior

n/a

Screenshots

No response

Versions and configuration

cdda-windows-tiles-x64-2024-05-16-0649

Additional context

No response

@IdleSol IdleSol added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label May 16, 2024
@GuardianDll
Copy link
Member

If you create a world with the Limb stuff mod and then delete it

it is something you shouldn't do, it is expected that removing mods cause errors

@GuardianDll GuardianDll closed this as not planned Won't fix, can't repro, duplicate, stale May 16, 2024
@GuardianDll GuardianDll added (S4 - Invalid) wontfix / can't reproduce / notabug and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels May 16, 2024
@IdleSol
Copy link
Author

IdleSol commented May 16, 2024

But I don't delete the mod from the world, I delete the world and create a new one

@GuardianDll You misunderstood or I misspelled it.

@Qrox
Copy link
Contributor

Qrox commented May 17, 2024

Sounds like some data are not properly unloaded before loading the new world.

@GuardianDll
Copy link
Member

huh; okay, that's one is my fault, sorry for this

@GuardianDll GuardianDll reopened this May 17, 2024
@GuardianDll GuardianDll added (S1 - Need confirmation) Report waiting on confirmation of reproducibility and removed (S4 - Invalid) wontfix / can't reproduce / notabug labels May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility
Projects
None yet
Development

No branches or pull requests

3 participants