-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Key16 support Two-Level Hash aggregation. #63667
base: master
Are you sure you want to change the base?
Conversation
This is an automated comment for commit fd81bbe with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
This looks good! But it is in question whether we should give up a fixed layout and do a costly conversion to two-level?
|
hi, I found for simplest aggregation functions such as parellel merging
single thread merging
|
@JackyWoo the solution is not to do any conversion at all, but have the data structure mergeable in parallel as is. |
I agree that convertible structure doesn't make a lot of sense for fixed size table. |
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Key16 support Two-Level Hash aggregation. Closes #63666.
Documentation entry for user-facing changes
Modify your CI run
NOTE: If your merge the PR with modified CI you MUST KNOW what you are doing
NOTE: Checked options will be applied if set before CI RunConfig/PrepareRunConfig step
Include tests (required builds will be added automatically):
Exclude tests:
Extra options:
Only specified batches in multi-batch jobs: