Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Options.Debugf is not used properly #1163

Closed
grongor opened this issue Dec 20, 2023 · 0 comments · Fixed by #1166
Closed

Options.Debugf is not used properly #1163

grongor opened this issue Dec 20, 2023 · 0 comments · Fixed by #1166
Labels
bug

Comments

@grongor
Copy link
Contributor

grongor commented Dec 20, 2023

Describe the bug

I've set the custom Debugf function in clickhouse.Options struct, but it is not used.

Steps to reproduce

  1. Use clickhouse.Options{Debug: true, Debugf: func(format string, v ...any) { }}
  2. Watch some logging info appear even though it should not (easy to test on Rows Close error: context canceled)

Configuration

Environment

  • Client version: v2.16.0
  • Language version: go1.21.5 linux/amd64
  • OS: Fedora release 39
  • Interface: database/sql compatible driver
@grongor grongor added the bug label Dec 20, 2023
@omurbekjk omurbekjk mentioned this issue Dec 23, 2023
Merged
3 tasks
jkaflik pushed a commit that referenced this issue Jan 15, 2024
@omurbekjk
resolves #1163 debugF function is not respected (#1166)
eb76971 
* fix(issue-1163): debugF function is not respected

* fix(issue-1163): address MR comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

resolves #1163 debugF function is not respected omurbekjk/clickhouse-go
1 participant
@grongor