Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added all query settings and implemented simple validation #1613

Merged
merged 4 commits into from
Apr 18, 2024
Merged

Added all query settings and implemented simple validation #1613

merged 4 commits into from
Apr 18, 2024

Conversation

chernser
Copy link
Contributor

Summary

Added query settings from existing client.
Implemented simple validation methods

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@chernser chernser linked an issue Apr 18, 2024 that may be closed by this pull request
[client-v2] Query API - QuerySettings #1599
Closed
2 tasks
Paultagoras
Paultagoras requested changes Apr 18, 2024
View reviewed changes
client-v2/pom.xml Show resolved Hide resolved
client-v2/src/main/java/com/clickhouse/client/api/Client.java Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 18, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
35.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@chernser chernser merged commit fdb8205 into main Apr 18, 2024
58 of 59 checks passed
@mshustov mshustov deleted the feature_query_settings branch April 26, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Paultagoras Paultagoras Paultagoras approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[client-v2] Query API - QuerySettings
3 participants
@chernser @CLAassistant @Paultagoras