Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a version for browser environment #2

Closed
mshustov opened this issue Jul 26, 2022 · 1 comment
Closed

Provide a version for browser environment #2

mshustov opened this issue Jul 26, 2022 · 1 comment
Labels
enhancement New feature or request question Further information is requested

Comments

@mshustov
Copy link
Member

mshustov commented Jul 26, 2022

The browser version of the client can provide limited functionality but with a similar API.
The integration tests must be run in both nodejs and browser envs.

In the first implementation, the client uses webpack to shim http module with a browser-compatible version. This approach doesn't allow us to implement env-specific logic for the network modules, so let's consider implementing a separate http_browser_adapter that might encapsulate browser-specific network logic. The separation can be done on the code level by using a dedicated browser entry point of package.json see https://docs.npmjs.com/cli/v8/configuring-npm/package-json#browser

@slvrtrn slvrtrn added enhancement New feature or request question Further information is requested labels Aug 30, 2022
@slvrtrn
Copy link
Contributor

slvrtrn commented Jul 14, 2023

Closing this as #165 was merged; we also have this now: #162

@slvrtrn slvrtrn closed this as completed Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants