Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compression settings #7

Open
mshustov opened this issue Jul 26, 2022 · 1 comment
Open

Add compression settings #7

mshustov opened this issue Jul 26, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@mshustov
Copy link
Member

Compression helps reduce the transferred data size at the cost of some CPU overhead. It might be beneficial to enable compression in environments with low network bandwidth.
The client doesn't support extended configuration for the compression settings. The binary switch is sufficient.
Settings:

interface Compression {
  // enable compression for the data transferred from ClickHouse to a client. Default value: true.
  read: boolean;
  // enable compression for the data transmitted from a client to the ClickHouse server. Default value: false.
  write: boolean
}

We need some performance benchmarks to justify enabling compression by default.

@mshustov mshustov self-assigned this Aug 8, 2022
@mshustov
Copy link
Member Author

mshustov commented Aug 8, 2022

implemneted in #16
I'm leaving the issue open to re-evaluating defaults after performance benchmarking.

@slvrtrn slvrtrn added the enhancement New feature or request label Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants