Skip to content
This repository has been archived by the owner on Nov 2, 2020. It is now read-only.

'disconnect' event is not triggered #55

Open
1 of 4 tasks
ramjak opened this issue Feb 14, 2019 · 3 comments
Open
1 of 4 tasks

'disconnect' event is not triggered #55

ramjak opened this issue Feb 14, 2019 · 3 comments
Assignees

Comments

@ramjak
Copy link
Contributor

ramjak commented Feb 14, 2019

Submitting

  • Bug
  • Question
  • Suggetion
  • Other

Using:

  1. ClusterWS v3.1.1
  2. OS Ubuntu 18.04

Desc:
'disconnect' event is not triggered after the socket is closed. After I check the disconnect event is missing in the event list in the EventEmitter.

17:20:33.702 emit {error: ƒ, connect: ƒ, response: ƒ, disconnect} connect
17:20:33.718 subscribe to to channel
17:20:33.719 status$: ON
17:20:33.764 emit {error: ƒ, connect: ƒ, response: ƒ} response

I've tried to check if off in the EventEmitter is triggered, but it's not.

@goriunov
Copy link
Member

Ohh that is interesting, i will check it out today.

@goriunov goriunov self-assigned this Feb 14, 2019
@goriunov
Copy link
Member

@ramjak i have run tests locally and seems like everything works correctly

First is calling close socket from frontend (works ok)

   <script>
        let socket = new ClusterWS({
            url: 'ws://localhost:3000'
        });

        socket.on("disconnect", (code, error) => {
            console.log("Should be called", code, error);
        });

        setTimeout(() => {
            console.log("Close socket");
            socket.disconnect();
        }, 5000)
    </script>

and second i tied calling close from back end (also works ok)

   <script>
        let socket = new ClusterWS({
            url: 'ws://localhost:3000'
        });

        socket.on("disconnect", (code, error) => {
            console.log("Should be called", code, error);
        });
    </script>

@goriunov
Copy link
Member

Can you please provide your code which does not work.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants