Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permission to integrate project into Krypton-NET-4.7 #6

Open
Wagnerp opened this issue Jan 27, 2018 · 7 comments
Open

Permission to integrate project into Krypton-NET-4.7 #6

Wagnerp opened this issue Jan 27, 2018 · 7 comments

Comments

@Wagnerp
Copy link

Wagnerp commented Jan 27, 2018

Hi @Cocotteseb,

Would it be possible to integrate this project into Krypton-NET-4.7 and the other .NET versions that I'm currently working on?

@Cocotteseb
Copy link
Owner

Sorry for not answering before.
I'm OK with the integration (it is under MS-PL license). A link to the original project would be great!

If you modify/add features it could be great to synchronize and vice-versa. (I think on github it does work with pull request right ?)

@Wagnerp
Copy link
Author

Wagnerp commented Feb 4, 2018

Thanks, is it ok to push a upgraded version to your repo, as there are lots of great features in C# 7 that will neaten up/streamline the code a bit?

@xiaoqianshijian
Copy link

i want to use this in my project, but my project is bases on .net4.0, visual studio 2015, when I Compiled the project, it has warninig, it said Failed to parse, this is based on .net4.5 ,which is heigher than .net4,

@Wagnerp
Copy link
Author

Wagnerp commented Aug 10, 2018

@xiaoqianshijian

You can't run it on a lower framework, unless you retarget & rebuild it for .NET 4.0.

@Cocotteseb
Copy link
Owner

Hi,

@xiaoqianshijian Can you try retargeting, there should be no special code that forbids you to compile at 4.0

@Wagnerp : the .NET 4.7 is supported on Windows 10 ; Windows 7 Service Pack 1; Windows 8.1; Windows Server 2008 R2 SP1; Windows Server 2012; Windows Server 2012 R2; Windows Server 2016

Fair enough compatibility. Do you have some interesting features in your fork that I may take a look at ?
I may be interested for accepting push requests concerning this subject. (but no foreach ;) )

@Wagnerp
Copy link
Author

Wagnerp commented Aug 21, 2018

@Cocotteseb

I think what @xiaoqianshijian is trying to do is to use a 4.7 version with a 4.0 version of their app. Of course you can have a look at my branch, I can't remember what changes I've made, as I haven't looked at that part of the code since February! ;)

@Wagnerp
Copy link
Author

Wagnerp commented Dec 21, 2019

Hi @Cocotteseb

I've pushed some updates that may interest you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants