partialy fix Bugs with yup v1 and arrays of non nullable #359 #388

erwan-joly · 2023-06-08T04:24:21Z

@Code-Hex this partially fix #359
unfortunately when having outer type field mandatory we are still having an issue

type InnerType2 {
  testScalar: MyScalar
}

type OuterType2 {
  inner: InnerType2!
}

throw the error

error TS1360: Type 'ObjectSchema<{ __typename: "OuterType2" | undefined; inner: any; }, AnyObject, { __typename: undefined; inner: any; }, "">' does not satisfy the expected type 'ObjectSchema<OuterType2, AnyObject, any, "">'.
  The types of 'default(...).__outputType' are incompatible between these types.
    Type '{ __typename?: "OuterType2" | undefined; inner?: any; }' is not assignable to type '{ __typename?: "OuterType2" | undefined; inner: InnerType2; }'.
      Property 'inner' is optional in type '{ __typename?: "OuterType2" | undefined; inner?: any; }' but required in type '{ __typename?: "OuterType2" | undefined; inner: InnerType2; }'.

Code-Hex · 2023-06-08T10:20:53Z

@erwan-joly Thank you!
However, this approach leads to the issue where the inferred type for the field becomes 'any' when it is self-referencing, which in turn prevents the 'satisfies' from compiling.

Not being able to compile would be a regression from the current situation, so I'm not convinced that this can be considered a partial fix. I'll be happy to merge if it can be confirmed that it allows for a successful compilation!

erwan-joly · 2023-06-08T10:39:35Z

Not sure sorry just tried to apply the suggested fix on yup if there is a good fix I think that would be better

Code-Hex · 2023-06-08T12:29:06Z

@erwan-joly This is example:

error is

$ tsc --strict --noEmit example/yup/schemas.ts
example/yup/schemas.ts:32:17 - error TS7023: 'ComponentInputSchema' implicitly has return type 'any' because it does not have a return type annotation and is referenced directly or indirectly in one of its return expressions.

32 export function ComponentInputSchema() {
                   ~~~~~~~~~~~~~~~~~~~~


Found 1 error in example/yup/schemas.ts:32

Your PR is using yup.Schema as the return type but it has not the type information is lost on the user side. If satisfies are used, the return value must not have any type of information. The results of type inference should be used instead.

Code-Hex · 2023-12-09T11:43:42Z

Temporary close this PR.

erwan-joly added 4 commits June 8, 2023 16:20

partialy fix Bugs with yup v1 and arrays of non nullable Code-Hex#359

6d29391

regenerate

6b384fc

fix tests

fbe2d88

lint

1fb27e7

Code-Hex mentioned this pull request Jun 8, 2023

Schema of type that references itself causes compile error jquense/yup#2023

Open

Code-Hex closed this Dec 9, 2023

Code-Hex mentioned this pull request Dec 9, 2023

Satisfies operator #467

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

partialy fix Bugs with yup v1 and arrays of non nullable #359 #388

partialy fix Bugs with yup v1 and arrays of non nullable #359 #388

erwan-joly commented Jun 8, 2023 •

edited

Code-Hex commented Jun 8, 2023

erwan-joly commented Jun 8, 2023

Code-Hex commented Jun 8, 2023 •

edited

Code-Hex commented Dec 9, 2023

partialy fix Bugs with yup v1 and arrays of non nullable #359 #388

partialy fix Bugs with yup v1 and arrays of non nullable #359 #388

Conversation

erwan-joly commented Jun 8, 2023 • edited

Code-Hex commented Jun 8, 2023

erwan-joly commented Jun 8, 2023

Code-Hex commented Jun 8, 2023 • edited

Code-Hex commented Dec 9, 2023

erwan-joly commented Jun 8, 2023 •

edited

Code-Hex commented Jun 8, 2023 •

edited