Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help: Tests Not Executing on macOS 13 (amd64) #141

Open
Code-Hex opened this issue Oct 9, 2023 · 4 comments
Open

Help: Tests Not Executing on macOS 13 (amd64) #141

Code-Hex opened this issue Oct 9, 2023 · 4 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@Code-Hex
Copy link
Owner

Code-Hex commented Oct 9, 2023

Describe the bug

make test on macOS 13 (amd64) is not executing tests.

See: https://github.com/Code-Hex/vz/actions/runs/6452512346/job/17514882857?pr=134

To Reproduce

make test

Expected behavior

Pass tests

Screenshots
If applicable, add screenshots to help explain your problem.

Environment that you use to compile (please complete the following information):

https://github.com/actions/runner-images/blob/main/images/macos/macos-13-Readme.md

@Code-Hex Code-Hex added bug Something isn't working help wanted Extra attention is needed labels Oct 9, 2023
@Code-Hex
Copy link
Owner Author

Code-Hex commented Oct 9, 2023

@cfergeau @balajiv113 Could you check this if possible? 🙏

@balajiv113
Copy link
Contributor

@Code-Hex
With lima we noticed that the macOS 13 runner is unstable and tend to fail when resource are highly used.
We found it to be mostly green (still fails at times) when used 1core and 1gb memort

Here since we are using go test, maybe different tests are running in parallel. We can try disabling by using go test -p 1 ./...

@cfergeau
Copy link
Contributor

cfergeau commented Oct 9, 2023

My amd64 macbook is still using macOS 12. The tests are passing locally on amd64+macOS 12, but the CI run is green in this scenario.

Seeing https://github.com/Code-Hex/vz/actions/runs/6452512346?pr=134 :

The job running on runner GitHub Actions 2 has exceeded the maximum execution time of 6 minutes.

it looks like the test does not have a lot of time allowed before being killed?

Code-Hex added a commit that referenced this issue Oct 9, 2023
@Code-Hex
Copy link
Owner Author

Code-Hex commented Oct 10, 2023

@balajiv113 Thank you. It seems like this issue is indeed occurring, and it's only affecting macOS 13. It's been quite challenging as it fails most of the time. It's a complex problem.

In CI, it seems like there are frequent failures with read/write operations on the Directory Share.

the macOS 13 runner is unstable and tend to fail when resource are highly used.

@cfergeau I fixed timeout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants