Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label is not added for all pull requests #15

Open
gasigo opened this issue Apr 29, 2020 · 6 comments
Open

Label is not added for all pull requests #15

gasigo opened this issue Apr 29, 2020 · 6 comments
Labels
🐛 bug Something isn't working

Comments

@gasigo
Copy link

gasigo commented Apr 29, 2020

I've noticed that the label it's not being added for every pull request. The latest pull request where the label was not added had two labels with spaces in it. May not be related though. Any idea what could be the problem?

Thanks in advance

@rgomezcasas
Copy link
Member

Could you paste here the output of the action? (deleting all sensitive data)

@rgomezcasas
Copy link
Member

This was also reported in #16 with the output, so I fixed it in #17 :)

@rgomezcasas rgomezcasas added the 🐛 bug Something isn't working label May 5, 2020
@KarimFikani
Copy link

@rgomezcasas I still don't see the label even after fix #17.

Here is my output:

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
/src/github.sh: line 12: null: unbound variable
Total modifications:
/src/labeler.sh: line 37: [: : integer expression expected
Labeling pull request with size/xl
/src/labeler.sh: line 39: [: : integer expression expected
/src/labeler.sh: line 41: [: : integer expression expected
/src/labeler.sh: line 43: [: : integer expression expected
jq: error (at :1): Cannot iterate over null (null)
Final labels: "size/xl"
{
"message": "Not Found",
"documentation_url": "https://developer.github.com/v3/issues/#edit-an-issue"
}
{
"message": "Not Found",
"documentation_url": "https://developer.github.com/v3/issues/comments/#create-a-comment"
}

@rgomezcasas rgomezcasas reopened this May 9, 2020
@KarimFikani
Copy link

@rgomezcasas also getting other errors too:

Total modifications:
Labeling pull request with size/xl
Final labels: "size/xl"
{
"message": "Not Found",
"documentation_url": "https://developer.github.com/v3/issues/#edit-an-issue"
}
{
"message": "Not Found",
"documentation_url": "https://developer.github.com/v3/issues/comments/#create-a-comment"
}

Not sure why the PR got labeled with size/xl and the PR has only +297 −98

@KarimFikani
Copy link

These errors show up when I changed

on: [pull_request] to on: [push]

because I wanted the size labeler to run on every push and not only when creating the pull request.

@AlexBeauchemin
Copy link

I fixed the issue by adding the correct permissions to the task and commenting out the github_api_url

permissions:
  issues: write
  pull-requests: write
steps:
  ...
          # github_api_url: 'api.github.com'  

johanseto added a commit to eduNEXT/eox-nelp that referenced this issue Feb 28, 2023
this due  [lines_labeler_issue] and related to [eox_theming_lines_labeler]

[eox_theming_lines_labeler]: https://github.com/eduNEXT/eox-theming/pull/44/files/66037f401e2cebe33baaec013312e79fcf77892#r1097332568
[lines_labeler_issue]: CodelyTV/pr-size-labeler#15
johanseto added a commit to eduNEXT/eox-nelp that referenced this issue Feb 28, 2023
This due  [lines_labeler_issue] and related to [eox_theming_lines_labeler].
[eox_theming_lines_labeler]: https://github.com/eduNEXT/eox-theming/pull/44/files/66037f401e2cebe33baaec013312e79fcf77892#r1097332568
[lines_labeler_issue]: CodelyTV/pr-size-labeler#15
johanseto added a commit to eduNEXT/eox-nelp that referenced this issue Feb 28, 2023
This due  [lines_labeler_issue] and related to [eox_theming_lines_labeler].
[eox_theming_lines_labeler]: https://github.com/eduNEXT/eox-theming/pull/44/files/66037f401e2cebe33baaec013312e79fcf77892#r1097332568
[lines_labeler_issue]: CodelyTV/pr-size-labeler#15

Co-authored-by: johanv26
johanseto added a commit to eduNEXT/eox-nelp that referenced this issue Feb 28, 2023
This due  [lines_labeler_issue] and related to [eox_theming_lines_labeler].
[eox_theming_lines_labeler]: https://github.com/eduNEXT/eox-theming/pull/44/files/66037f401e2cebe33baaec013312e79fcf77892#r1097332568
[lines_labeler_issue]: CodelyTV/pr-size-labeler#15

Co-authored-by: johanv26
johanseto added a commit to eduNEXT/eox-nelp that referenced this issue Feb 28, 2023
This due  [lines_labeler_issue] and related to [eox_theming_lines_labeler].
[eox_theming_lines_labeler]: https://github.com/eduNEXT/eox-theming/pull/44/files/66037f401e2cebe33baaec013312e79fcf77892#r1097332568
[lines_labeler_issue]: CodelyTV/pr-size-labeler#15.

Co-authored-by: johanv26
johanseto added a commit to eduNEXT/eox-nelp that referenced this issue Feb 28, 2023
This due  [lines_labeler_issue] and related to [eox_theming_lines_labeler]
[eox_theming_lines_labeler]: https://github.com/eduNEXT/eox-theming/pull/44/files/66037f401e2cebe33baaec013312e79fcf77892#r1097332568
[lines_labeler_issue]: CodelyTV/pr-size-labeler#15.

Co-authored-by: johanv26
johanseto added a commit to eduNEXT/eox-nelp that referenced this issue Feb 28, 2023
johanseto added a commit to eduNEXT/eox-nelp that referenced this issue Feb 28, 2023
johanseto added a commit to eduNEXT/eox-nelp that referenced this issue Feb 28, 2023
johanseto added a commit to eduNEXT/eox-nelp that referenced this issue Feb 28, 2023
johanseto added a commit to eduNEXT/eox-nelp that referenced this issue Feb 28, 2023
This related to issue of action in CodelyTV/pr-size-labeler#15.
and eox-plugins decisions
https://github.com/eduNEXT/eox-theming/pull/44/files/66037f401e2cebe33baaec013312e79fcf77892
but the issue explain the permission solution.
footer
Co-authored-by: johanv26
johanseto added a commit to eduNEXT/eox-nelp that referenced this issue Feb 28, 2023
fix: pr issue assignment

fix: lines labeler action version

This related to issue of action in CodelyTV/pr-size-labeler#15.
and eox-plugins decisions
https://github.com/eduNEXT/eox-theming/pull/44/files/66037f401e2cebe33baaec013312e79fcf77892
but the issue explain the permission solution.
footer
Co-authored-by: johanv26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants