Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commands.Context object to extract the author id #6367

Closed

Conversation

sxliang3093
Copy link

@sxliang3093 sxliang3093 commented Apr 25, 2024

Description of the changes

I passed a commands.Context object to extract the author id. I changed the arguments of the autoplay function to encompass this change. This is for issue #6281

Closes #6281

Have the changes in this PR been tested?

No

@github-actions github-actions bot added the Category: Cogs - Audio This is related to the Audio cog. label Apr 25, 2024
@Flame442 Flame442 added the Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. label Apr 25, 2024
@aikaterna
Copy link
Member

Check out the additional context section I wrote on the linked issue. This probably isn't the way this should be resolved.

@Flame442
Copy link
Member

I know this is still a draft, but here's some tips about what is currently missing to get you on the right track:

  • You aren't actually passing ctx to the autoplay method, you changed its signature without changing any of the places that method is called.
    • This logic wouldn't work for resuming autoplay on bot start, not from a command.
    • Additionally, the notes of the issue you are resolving request a different solution for this issue:

      The fact that user playlists don't work for auto play is intentional - because auto play is a guild level feature meaning guild and global scoped playlists should work for it, but user not so, as we may exposing user data to users in a server that the playlist author/manager is no longer in.
      There should be an error show to the user when trying to set a user scoped playlist as an autoplay playlist.

  • You need to use the black autoformatter to style the updated code, in accordance with the CONTRIBUTING.MD file.

@Kowlin
Copy link
Member

Kowlin commented May 2, 2024

Due to the lack of activity on this PR, I'm gonna go ahead and close this.

@Kowlin Kowlin closed this May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Cogs - Audio This is related to the Audio cog. Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Audio] Autoplay failure with User scope playlist
4 participants