[Audio] disconnect command should check if the user is actually in the VC

[cool-aid-man]

What Red version are you using?

3.5.9

Cog name

Audio

Command name

disconnect

What did you expect to happen?

• Just like the summon command - the disconnect cmd should also check if the user (who is invoking the command) actually is in the VC before letting them disconnect the bot from the VC - where it's already playing songs along with other humans.
  

What actually happened?

It lets anyone who is not in the VC, run the command resulting in the bot getting disconnected from the VC, leading to an unpleasant experience.

How can we reproduce this error?

1. Connect to a VC
2. Set the vote percentage to 0 by audioset vote 0
3. Summon the bot to join
4. Ask any user or <p>mock anyone to run <p>disconnect
   Result - It should let that user x disconnect the bot without having to be there in the VC.

The summon command ONLY works if you are in the VC - likewise, the disconnect should also work if the user is in the VC, regardless of the status of the audioset vote.

Same result with or without the human. (Meaning if the bot is alone or with other users doesn't matter)

Anything else?

N/A

[aikaterna]

Sounds like the person that ran disconnect is a priviledged user like a server owner or a mod or admin set through Red.

[aikaterna]

Also another thing to note is that the permissions system for audio will not adhere to restrictions if there is no one in the channel or if they are alone.

[cool-aid-man]

Sounds like the person that ran disconnect is a priviledged user like a server owner or a mod or admin set through Red.

Hi aika, I can confirm that this is not the case here,

• I joined as server owner + with the bot in a VC - so the bot is not alone.
• The user neither has the moderator nor admin privilege not even set by the set command - In fact the user doesn't have any perms besides send_message.
• The bot doesn't have permissions override set by permissions cog, I had cleared all the permissions just to be extra safe.
• There's no DJ role set through the audioset dj.
• Audioset vote is set to 0 audioset vote 0 (If the audioset vote is set to any percentage then it would have asked the user - "There are other people listening - vote to skip instead.")

[ProfessorFartsalot]

I also have this issue. I can summon my Red instance to a voice channel, and my alt account (with only the @\everyone role) can disconnect the instance despite the user not being in the voice channel.

Edit: clarification, accidental ping, the sky is now on fire...

[ProfessorFartsalot]