Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no helpful error message if model file not found #668

Open
mssammon opened this issue Jul 20, 2018 · 2 comments
Open

no helpful error message if model file not found #668

mssammon opened this issue Jul 20, 2018 · 2 comments
Assignees
Labels

Comments

@mssammon
Copy link
Contributor

mssammon commented Jul 20, 2018

no indication that minio looked anywhere -- am I wrong? just an error about path it tried that did not work. Looks like there is now a disconnect between the name specified in the default config files (for conll and ontonotes) and the actual string used to build the path to check for models. "Main" class does the checks, but other older entrypoints don't.
Update the Main class to allow default args of input and output folder + config file. Consider scrapping the main() method in NerTagger, after adding any missing functionality to Main.

@mssammon
Copy link
Contributor Author

mssammon commented Sep 6, 2018

@cowchipkid this was in the context of using NER; I'm pretty sure your recent changes are relevant/might have solved this issue. Any thoughts?

@cowchipkid
Copy link
Contributor

The way this works now is that it will first check the file system. If not found, it checks the classpath. And if it is not there, it will check the view name. If the view name contains NER_CONLL it will load the default CoNLL model, it if contains NER_ONTONOTES, it will load the default Ontonotes model. Finally, if the view name does not match either of these names, it will throw an illegal argument exception. Not of my most recent changes impacted this, but I did change this I think 2 revs ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants