Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests fail with python 3.10 #277

Open
nonamedotc opened this issue Apr 8, 2021 · 2 comments
Open

tests fail with python 3.10 #277

nonamedotc opened this issue Apr 8, 2021 · 2 comments

Comments

@nonamedotc
Copy link

Describe Your Environment

Building qdarkstyle with fedora 35 (rawhide) and python 3.10 alpha

[Versions from your environment]

  • QDarkStyle: 3.0.2
  • OS: Linux (Fedora 35)
  • Python: 3.10 alpha

Language

Python

Description / Steps to Reproduce [if necessary]

[Description of the issue]

I am trying to build version 3.0.2 against python 3.10 alpha. Two of the tests fail due to changes in python 3.10.

Relevant python changes - https://docs.python.org/3.10/whatsnew/changelog.html#python-3-10-0-alpha-6

Actual Result

utils (unittest.loader._FailedTest) ... ERROR
qdarkstyle.utils (unittest.loader._FailedTest) ... ERROR

======================================================================
ERROR: utils (unittest.loader._FailedTest)
----------------------------------------------------------------------
ImportError: Failed to import test module: utils
Traceback (most recent call last):
  File "/usr/lib64/python3.10/unittest/loader.py", line 154, in loadTestsFromName
    module = __import__(module_name)
  File "/builddir/build/BUILD/QDarkStyle-3.0.2/qdarkstyle/utils/__init__.py", line 18, in <module>
    from qdarkstyle.utils.scss import create_qss
  File "/builddir/build/BUILD/QDarkStyle-3.0.2/qdarkstyle/utils/scss.py", line 14, in <module>
    import qtsass
  File "/usr/lib/python3.10/site-packages/qtsass/__init__.py", line 14, in <module>
    from qtsass.api import compile, compile_filename, compile_dirname, watch
  File "/usr/lib/python3.10/site-packages/qtsass/api.py", line 13, in <module>
    from collections import Sequence, Mapping
ImportError: cannot import name 'Sequence' from 'collections' (/usr/lib64/python3.10/collections/__init__.py)


======================================================================
ERROR: qdarkstyle.utils (unittest.loader._FailedTest)
----------------------------------------------------------------------
ImportError: Failed to import test module: qdarkstyle.utils
Traceback (most recent call last):
  File "/usr/lib64/python3.10/unittest/loader.py", line 470, in _find_test_path
    package = self._get_module_from_name(name)
  File "/usr/lib64/python3.10/unittest/loader.py", line 377, in _get_module_from_name
    __import__(name)
  File "/builddir/build/BUILD/QDarkStyle-3.0.2/qdarkstyle/utils/__init__.py", line 18, in <module>
    from qdarkstyle.utils.scss import create_qss
  File "/builddir/build/BUILD/QDarkStyle-3.0.2/qdarkstyle/utils/scss.py", line 14, in <module>
    import qtsass
  File "/usr/lib/python3.10/site-packages/qtsass/__init__.py", line 14, in <module>
    from qtsass.api import compile, compile_filename, compile_dirname, watch
  File "/usr/lib/python3.10/site-packages/qtsass/api.py", line 13, in <module>
    from collections import Sequence, Mapping
ImportError: cannot import name 'Sequence' from 'collections' (/usr/lib64/python3.10/collections/__init__.py)

Expected Results / Proposed Result

Expectation is that tests do not fail and package builds successfully.

@tirkarthi
Copy link

This was fixed in qtsass but seems to have not made it to a release : spyder-ide/qtsass#54

@dalthviz
Copy link

dalthviz commented Sep 5, 2022

Just in case, qtsass 0.3.1 was just released 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants