Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] switch to string constants in JS #2704

Closed
XhmikosR opened this issue May 28, 2020 · 2 comments 路 Fixed by #2830
Closed

[FEATURE] switch to string constants in JS #2704

XhmikosR opened this issue May 28, 2020 · 2 comments 路 Fixed by #2830

Comments

@XhmikosR
Copy link
Contributor

XhmikosR commented May 28, 2020

I recently did this on Bootstrap itself for both our master and v4-dev branches.

@REJack As you can see the results are pretty big. 馃檪

Would be nice if you made the change on AdminLTE itself.

PS. we have released a v4.5.0 upstream, but there are a couple of regressions we have to fix. After v4.5.1 is out, you should definitely update to that.

@REJack
Copy link
Collaborator

REJack commented May 28, 2020

That's a really nice idea, I had also the idea to replace the constants before. But I saw no benefit from it, but now I see it reduces the JS file size 馃槃. I'll change while the v3.1 development.

@REJack REJack added this to To do in v3.1.0 via automation May 28, 2020
@REJack REJack added this to the v3.1.0 milestone May 28, 2020
@XhmikosR
Copy link
Contributor Author

XhmikosR commented Jun 1, 2020

I'll take a stab at it after the current PRs are sorted. Have you thought about adding bundlewatch to monitor the sizes?

v3.1.0 automation moved this from To do to Done Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v3.1.0
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants