Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use magnitude and phase in the user interface of a model instead of real and imaginary part #161

Open
spflueger opened this issue Nov 13, 2020 · 0 comments
Open

Use magnitude and phase in the user interface of a model instead of real and imaginary part #161

spflueger opened this issue Nov 13, 2020 · 0 comments
Labels
❔ Question Discuss this matter in the team

Comments

@spflueger
Copy link
Member

spflueger commented Nov 13, 2020 •
edited

Intrinsically the amplitude models by default work with real and imaginary numbers, which allows the fit to be unconstrained (no mag > 0 and 2 pi phase jumps) hence more stable. In the user interface a conversion to magnitude and phi is however more intuitive.
@redeboer redeboer mentioned this issue Nov 26, 2020
Merged
@spflueger spflueger mentioned this issue Nov 26, 2020
Closed
@spflueger spflueger changed the title Use real and imaginary part in the complex parameter description of an Amplitude Use magnitude and phase in the user interface of a model instead of real and imaginary part Mar 4, 2021
@spflueger spflueger added the ❔ Question Discuss this matter in the team label Mar 4, 2021
@redeboer redeboer modified the milestone: Release 0.2.2 Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
❔ Question Discuss this matter in the team
Projects
Student projects
Status: 🆕 Icebox
Milestone
No milestone
Development

No branches or pull requests
2 participants
@spflueger @redeboer