Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating NodeJS version #1637

Closed
AlexanderMaxRanabel opened this issue May 10, 2023 · 2 comments
Closed

Updating NodeJS version #1637

AlexanderMaxRanabel opened this issue May 10, 2023 · 2 comments
Labels
⚙️ dependencies Pull requests that update a dependency file

Comments

@AlexanderMaxRanabel
Copy link

Question

It has come to my attention that the current NodeJS versions which are currently being supported by CSS have already reached their end of life. This could potentially result in unforeseen complications in the future. In light of this, I would like to propose updating CSS to utilize the latest NoneJS LTS version(18.16.0).
@joachimvh joachimvh added the ⚙️ dependencies Pull requests that update a dependency file label May 11, 2023
@joachimvh
Copy link
Member

You're right, for some reason I thought their end of life was further in the future. Node 14 just reached end of life. 16 is still maintained until September. We can look into doing this for the next major release to not break anything for current installations.

The good news is that this would also allow us to update the oidc-provider library to the next major version.

mrkvon added a commit to OpenHospitalityNetwork/sleepy.bike that referenced this issue May 27, 2023
@mrkvon
Use Node v16 for testing
9a8dde5 
We still need to use Node v16, because CommunitySolidServer doesn't
support v18
CommunitySolidServer/CommunitySolidServer#1637
mrkvon added a commit to OpenHospitalityNetwork/sleepy.bike that referenced this issue May 27, 2023
@mrkvon
Add github workflow to run cypress tests on every push (#23)
764dd13 
also update @inrupt/solid-client-authn-browser to support latest Node
inrupt/solid-client-authn-js#2803
but we still need to use Node v16, because of CSS
CommunitySolidServer/CommunitySolidServer#1637
@joachimvh joachimvh mentioned this issue Jun 16, 2023
Merged
@joachimvh
Copy link
Member

Done in #1661

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
⚙️ dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joachimvh @AlexanderMaxRanabel