-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Threads embed #1749
feat: add Threads embed #1749
Conversation
packages/@atjson/offset-annotations/src/annotations/threads-embed.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! For this I think we need some tests
@Indrani-Gostu I fixed the There was some other work that I did to fix the cascading type info, but this maybe could help :) |
Thanks @tim-evans |
Well, kind of annoying— there's an SVG that's showing up in the content that we don't want. We kind of only want the You can see some of my code to work around this for Instagram embeds in this PR: #1753 |
I've posted some changes on #1761 to tweak this PR into a state that I'd like it to be in for merging :) |
return { | ||
Class: ThreadsEmbed, | ||
attributes: { | ||
url: `${url.protocol}//${url.host}${url.pathname}`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would normalize the protocol here
f44ea88
to
fb99b3b
Compare
Meta's threads application is gaining support and we are adding support for embedding and identifying posts and turning them into blocks.
For reference we would like this HTML embed code to end up as a block with the following info:
nb. If threads supports embed codes that contain the textual content of the post in the future, we would want to store that instead of this link out to their walled garden, especially if posts get deleted or the product gets discontinued at some point in the future.