Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The user can create the Kafka destination connector with an invalid value "-1" #42

Open
uchennakevinm1 opened this issue Aug 27, 2022 · 2 comments

Comments

@uchennakevinm1
Copy link

uchennakevinm1 commented Aug 27, 2022

The user can create the Kafka destination connector with an invalid value "-1" for  the number of acknowledgments required before considering a record written to Kafka ( "acks": "-1" )
 
Expected result: Error: "message": "failed to create connector: could not init connector: invalid destination config: config is invalid: couldn't parse ack: unknown ack mode: required acks must be one of none, one, or all, not "-1""
 
Valid values: none, one, all. 

GitHub - ConduitIO/conduit-connector-kafka: Provides a source and a destination Kafka connector, for Conduit.

Image

@uchennakevinm1
Copy link
Author

@hariso need to check documentation because -1 is a valid value

@hariso
Copy link
Contributor

hariso commented Aug 29, 2022

We're using Segment client's acks.UnmarshalText method here, which is also able to handle integer values for this parameter. So it's valid to use:

  • none, one, all (text version)
  • 0, 1, -1 (int version).

We need to update the docs to mention this possibility too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants